Document the NormalizeOpts Default impl better #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that the Default impl of the normalize::NormalizeOpts type disables all options, as it is not obvious how it behaves otherwise. Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o
force-pushed
the
topic/normalize-opts-default
branch
from
19ad6a8 to
ad454b6
Compare
d-e-s-o
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 59 59
Lines 10930 10930
=======================================
Hits 10378 10378
Misses 552 552 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that the
Defaultimpl of thenormalize::NormalizeOptstype disables all options, as it is not obvious how it behaves otherwise.