Make create_apk_elf_path() infallible #1033
Merged
+44
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the minimum supported Rust version to 1.70. Switching to this version will allow us to use PathBuf::as_mut_os_string(). Signed-off-by: Daniel Müller <[email protected]>
It doesn't really make much sense for the create_apk_elf_path() helper to be fallible. Conceptually at least, the algorithm is super straight forward and there is no reason to report an error just because no APK path is present. Yes, it's a logical error of sorts, but it's a logical error everywhere else as well, not just in this function. Adjust the logic to be a bit more robust (or at least easier to grasp) and to not emit any errors. Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o
force-pushed
the
topic/apk-path-rework
branch
from
33865ac to
5388db9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
- Coverage 94.96% 94.95% -0.01%
==========================================
Files 60 60
Lines 10942 10948 +6
==========================================
+ Hits 10391 10396 +5
- Misses 551 552 +1 ☔ View full report in Codecov by Sentry. |
d-e-s-o
force-pushed
the
topic/apk-path-rework
branch
from
5388db9 to
8f6a274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't really make much sense for the create_apk_elf_path() helper to be fallible. Conceptually at least, the algorithm is super straight forward and there is no reason to report an error just because no APK path is present. Yes, it's a logical error of sorts, but it's a logical error everywhere else as well, not just in this function. Adjust the logic to be a bit more robust (or at least easier to grasp) and to not emit any errors.