capi: Use our "Input" terminology in C API #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a divergence between the terminology we use for the Input enum in Rust code and the suffixes we added to the symbolization functions in the C API. This change unifies the two to minimize the potential for confusion. Signed-off-by: Daniel Müller <[email protected]>
|
Respin of #457. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 92.31% 92.33% +0.01%
==========================================
Files 41 41
Lines 6399 6415 +16
==========================================
+ Hits 5907 5923 +16
Misses 492 492 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a divergence between the terminology we use for the Input enum in Rust code and the suffixes we added to the symbolization functions in the C API.
This change unifies the two to minimize the potential for confusion.