Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent test failure #5

Closed
petroav opened this issue Jan 22, 2019 · 1 comment
Closed

Intermittent test failure #5

petroav opened this issue Jan 22, 2019 · 1 comment

Comments

@petroav
Copy link
Contributor

petroav commented Jan 22, 2019

Running package tests locally occasionally fails with

--- FAIL: TestAllocations (0.00s)
	~/go/src/github.com/libp2p/go-buffer-pool/pool_test.go:31: expected less than 100 frees after GC, got 527
FAIL
coverage: 96.4% of statements
FAIL	github.com/libp2p/go-buffer-pool	0.323s
Error: Tests failed.

@Stebalien should I investigate the failure? I see most of the code was taken from Go source with small modifications. I wanted to add Travis build and coverage files to the repo and ran into this.
@Stebalien
Copy link
Member

We can probably just bump the limit to 1000. If there's a bug, we'll get 10,000 frees.

@petroav petroav mentioned this issue Jan 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @petroav