-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the peer that delivered the message #215
Comments
Do we think this is sufficiently reusable such that we're better off recommending this approach rather than the hackier, but already available, approach of using the validators? Note, that the validators take the peer that delivered the message as an input so we actually already have an avenue for getting the |
Using the validators is just too hacky, let's expose |
Closed in #218. |
It may be useful for peers that want to layer protocols on top of pubsub to know which peer actually delivered a message to them.
We already have this information available in the
from
field of the RPC:go-libp2p-pubsub/pubsub.go
Lines 144 to 149 in 2247a54
so this would mean making the information publicly available in the Message struct:
go-libp2p-pubsub/pubsub.go
Lines 136 to 138 in 2247a54
The text was updated successfully, but these errors were encountered: