Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WithReachability option #874

Closed
Stebalien opened this issue Apr 7, 2020 · 1 comment · Fixed by #878
Closed

Rename WithReachability option #874

Stebalien opened this issue Apr 7, 2020 · 1 comment · Fixed by #878
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Stebalien
Copy link
Member

This option did not pass the "wtf is this thing" test with @daviddias. We should consider calling it something like ForceReachability or even AssumePublic/AssumePrivate, ... I'm not sure. Just something else.

Thoughts @willscott?
@Stebalien Stebalien added the kind/enhancement A net-new feature or improvement to an existing feature label Apr 7, 2020
@daviddias
Copy link
Member

Just leaving my suggestion here, given that AutoNAT is a subsystem (AFAIK), I propose that it is something like libp2p.AutoNatAssumePublic or similar (as long as AutoNat is in the name) so that the reader and developer knows which subsystem consumes this option.

@willscott willscott mentioned this issue Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clearer naming of nat override options libp2p/go-libp2p
2 participants
@Stebalien @daviddias