Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(identify): move log to debug level #3206

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented Feb 24, 2025

We've started seeing this ERROR in long-running Kubo nodes:

2025-02-23T23:15:04.924Z	ERROR	net/identify	identify/id.go:801	error getting peer record from Identify message: failed to validate envelope: invalid signature or incorrect domain
2025-02-24T03:14:47.091Z	ERROR	net/identify	identify/id.go:801	error getting peer record from Identify message: failed to validate envelope: invalid signature or incorrect domain

Seems to occur quite often these days, likely due to some custom clients probing network.

This PR is moving this message to debug since (1) it is not a hard error (2) other errors of similar non-fatal category log to debug already

ERROR like:

"error getting peer record from Identify message: failed to validate
envelope: invalid signature or incorrect domain"

seems to occur often these days, likely due to some custom clients
probing network – moving to debug since other errors of similar category
are there already
@lidel lidel requested a review from sukunrt February 24, 2025 18:36
@MarcoPolo MarcoPolo merged commit 93a1d3f into master Feb 25, 2025
9 checks passed
@lidel lidel mentioned this pull request Feb 25, 2025
40 tasks
@MarcoPolo MarcoPolo mentioned this pull request Feb 25, 2025
19 tasks
@lidel lidel deleted the fix-adjust-log-level branch February 25, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants