Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: maximum call stack size with duplicate webrtc addresses #2980

Merged
merged 3 commits into from
Feb 21, 2025
Merged

fix: maximum call stack size with duplicate webrtc addresses #2980

merged 3 commits into from
Feb 21, 2025
+57 −1

Conversation

dozyio
Copy link
Contributor

@dozyio dozyio commented Feb 21, 2025 •
edited by achingbrain
Loading

Description

Fixes #2539

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@dozyio dozyio requested a review from a team as a code owner February 21, 2025 02:03
@achingbrain achingbrain merged commit d98cc46 into libp2p:main Feb 21, 2025
35 checks passed
@achingbrain
Copy link
Member

Thanks!

@achingbrain achingbrain mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: max call stack exceeded when duplicate /webrtc listeners added
2 participants
@dozyio @achingbrain