Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency of mplex and yamux settings #1531

Closed
mikevoronov opened this issue Mar 30, 2020 · 2 comments · Fixed by #1822
Closed

Consistency of mplex and yamux settings #1531

mikevoronov opened this issue Mar 30, 2020 · 2 comments · Fixed by #1822

Comments

@mikevoronov
Copy link
Contributor

At now, mplex and yamux have different naming in setting builder like
MplexConfig vs Config
max_num_subtreams vs set_max_num_substreams
max_buffer_size vs set_max_num_substreams

I think it would be convenient to have the same naming scheme for both mplex and yamux. And for me, yamux scheme looks more impressively.

@mikevoronov mikevoronov changed the title Consistency beetwen mplex and yamux settings Consistency of mplex and yamux settings Mar 30, 2020
@ericjmiller
Copy link

New to Rust, looking to contribute to libp2p.

It seems mplex is contained within rust-libp2p, while yamux is an external module whose API we don't control. Are you suggesting a change to yamux (here)?

@mxinden
Copy link
Member

mxinden commented Oct 12, 2020

New to Rust, looking to contribute to libp2p.

@ericjmiller cool.

while yamux is an external module whose API we don't control.

Not quite. Yamux is an open source project in the sense that it welcomes comments and contributions, but as usual there is no guarantee for those suggestions to be included.

Are you suggesting a change to yamux (here)?

I would suggest changing the mplex implementation so that it matches the yamux naming scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants