You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At now, mplex and yamux have different naming in setting builder like MplexConfig vs Config max_num_subtreams vs set_max_num_substreams max_buffer_size vs set_max_num_substreams
I think it would be convenient to have the same naming scheme for both mplex and yamux. And for me, yamux scheme looks more impressively.
The text was updated successfully, but these errors were encountered:
mikevoronov
changed the title
Consistency beetwen mplex and yamux settings
Consistency of mplex and yamux settings
Mar 30, 2020
It seems mplex is contained within rust-libp2p, while yamux is an external module whose API we don't control. Are you suggesting a change to yamux (here)?
while yamux is an external module whose API we don't control.
Not quite. Yamux is an open source project in the sense that it welcomes comments and contributions, but as usual there is no guarantee for those suggestions to be included.
Are you suggesting a change to yamux (here)?
I would suggest changing the mplex implementation so that it matches the yamux naming scheme.
At now, mplex and yamux have different naming in setting builder like
MplexConfig
vsConfig
max_num_subtreams
vsset_max_num_substreams
max_buffer_size
vsset_max_num_substreams
I think it would be convenient to have the same naming scheme for both mplex and yamux. And for me, yamux scheme looks more impressively.
The text was updated successfully, but these errors were encountered: