Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kademlia graceful shutdown #2164

Closed
rubdos opened this issue Jul 27, 2021 · 2 comments
Closed

Kademlia graceful shutdown #2164

rubdos opened this issue Jul 27, 2021 · 2 comments

Comments

@rubdos
Copy link
Contributor

rubdos commented Jul 27, 2021

I'm not 100% on what the libp2p specs say, but should the Kademlia subsystem implement a graceful shutdown, or at least have the option to do so?

Such a shutdown should probably entail stopping to accept new records, and re-replicating the locally available records.

@mxinden
Copy link
Member

mxinden commented Jul 28, 2021

but should the Kademlia subsystem implement a graceful shutdown

I haven't had the need for it thus far, though I am not opposed to it. Would you mind expanding on your concrete use-case?

Also see #1682 for a similar effort on the larger libp2p level.

@rubdos
Copy link
Contributor Author

rubdos commented Jul 28, 2021

Would you mind expanding on your concrete use-case?

Sure! It's mostly in my current test case, where I have between 50 and 300 nodes running on Kubernetes to do some tests. I notice that Kubernetes is quite aggressive in scaling down, so when I start testing with actual content on the network, I'm afraid that stuff will get lost.

I guess in real-life this shouldn't™ happen, statistically speaking.

Another case would be extremely low $k$ or $\alpha$ values. I recall reading a paper about using $k=2$ and $k=4$ settings, where they required graceful shutdown and some other tricks to really get the replication factors down to extremely low values. I've given my Zotero a quick skim, but can't seem to currently find the paper.

@thomaseizinger thomaseizinger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants