Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add a mergify automation that notifies us of "stalled" PRs #3813

Open
thomaseizinger opened this issue Apr 22, 2023 · 2 comments
Open

ci: add a mergify automation that notifies us of "stalled" PRs #3813

thomaseizinger opened this issue Apr 22, 2023 · 2 comments
Labels
getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted

Comments

@thomaseizinger
Copy link
Contributor

Description

Sometimes, a PR with a send-it label stalls due to a failing build. It is easy to forget about those. We should add an automation rule that notifies us in PRs with a send-it label and a failing build. Those will require manual intervention.

Perhaps we could even automatically requeue it once (apply a label to avoid an infinite loop?).

Obviously, we should instead fix the flaky test (looking at you webrtc-rs 👀). In the meantime, this could increase our development velocity.

Related: #3659.

Motivation

Requirements

Open questions

Are you planning to do it yourself in a pull request?

Yes / No / Maybe.

@thomaseizinger thomaseizinger added help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Apr 22, 2023
@drHuangMHT
Copy link
Contributor

I looked into mergify documentation and it seems that there is no condition that checks for the duration since a label is applied. However we can check against time when the PR enters merge queue. So here is the question: is the PR put in queue immediate after send-it label is applied?

@jxs
Copy link
Member

jxs commented Sep 30, 2024

I looked into mergify documentation and it seems that there is no condition that checks for the duration since a label is applied. However we can check against time when the PR enters merge queue. So here is the question: is the PR put in queue immediate after send-it label is applied?

Hi drHuang, no it needs to fullfill the remaining conditions:

  • all conversations resolved
  • required CI green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Projects
None yet
Development

No branches or pull requests

3 participants