-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(multidim-interop): add go v0.31 #289
Conversation
Resolved by #295. |
@marten-seemann #295 adds this to perf/ not multidim-interop/ |
Failure is a flaky test: chromium-js-v0.46 x rust-v0.52 (webrtc-direct),failure |
Sorry, I must have missed that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing v0.29? It's the version that's used on the latest Kubo release? What's the policy you're following here to drop v0.27 and v0.28?
We should consider dropping v0.30 though, because it was never deployed.
v0.27 and v0.28 were already removed in #269 - I'm doing some cleanup in this PR No strict policy but the rationale for removing older versions was discussed here: https://filecoinproject.slack.com/archives/C03K82MU486/p1691624748108769 i.e. we can use the PRs as a place to decide whether it's ok to remove an old version. If you think we should keep v0.29 for a bit longer I'm ok to add it back. |
I don't see why. We should be testing what's in use. v0.30 was primarily a release to get Go 1.21 compatibility in. |
Let's keep it and drop it when 0.32 is released? Unless you feel super strongly this is my preference |
As long as we keep testing v0.29, this is fine. I see you re-added it, can you update the title of this PR as well? |
Done |
No description provided.