From 3558fd7baf9c1c477f5a830f82282e242bcaf5f4 Mon Sep 17 00:00:00 2001 From: John-Lin Date: Tue, 17 Jul 2018 09:21:28 +0800 Subject: [PATCH 1/2] add test for invalid NFS IP Former-commit-id: 2371d7146c7243b4bdf9f4bcee74f7f89e25b1af [formerly 2371d7146c7243b4bdf9f4bcee74f7f89e25b1af [formerly a8053ed7f29ba0106297bdfb8da421405d4558a3]] Former-commit-id: cb76381cbb339ed4a15f044fac78a1ed36b5d51a Former-commit-id: 6ecb3ad08119eab6f28609d72d4d56a94e2779f0 --- src/server/handler_storage_test.go | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/server/handler_storage_test.go b/src/server/handler_storage_test.go index 6cea5571..029f3058 100644 --- a/src/server/handler_storage_test.go +++ b/src/server/handler_storage_test.go @@ -122,18 +122,31 @@ func (suite *StorageTestSuite) TestCreateStorageFail() { Fake: &entity.FakeStorage{ FakeParameter: "Yo", IWantFail: true, - }}, + }, + }, http.StatusInternalServerError}, + {"inValidNFSIP", entity.Storage{ + Type: entity.FakeStorageType, + Name: namesgenerator.GetRandomName(1), + StorageClassName: namesgenerator.GetRandomName(0), + IP: "256.256.256.256", + PATH: "/myspace", + Fake: &entity.FakeStorage{ + FakeParameter: "Yo", + }, + }, + http.StatusBadRequest}, {"StorageTypeError", entity.Storage{ Name: namesgenerator.GetRandomName(0), StorageClassName: namesgenerator.GetRandomName(1), - Type: "non-exist", + Type: "none-exist", IP: "192.168.5.100", PATH: "/myspace", Fake: &entity.FakeStorage{ FakeParameter: "Yo", IWantFail: true, - }}, + }, + }, http.StatusBadRequest}, } From be71a4be39d91b5e5c04386cc0cf3cfd67f1679c Mon Sep 17 00:00:00 2001 From: John-Lin Date: Tue, 17 Jul 2018 09:36:41 +0800 Subject: [PATCH 2/2] add more test Former-commit-id: e054ed417eecd057a7897f8bb0fdcb1ab4f91050 [formerly e054ed417eecd057a7897f8bb0fdcb1ab4f91050 [formerly 478ff96c5ce97f925f75d208cc7df9a8df94fa96]] Former-commit-id: fbb41f105911f6f9a8bed96cd95e90551ba0656b Former-commit-id: 2dbccb90fe5759019ae8f27ac81338cf92862e35 --- src/server/handler_storage_test.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/server/handler_storage_test.go b/src/server/handler_storage_test.go index 029f3058..462ecf0b 100644 --- a/src/server/handler_storage_test.go +++ b/src/server/handler_storage_test.go @@ -136,6 +136,16 @@ func (suite *StorageTestSuite) TestCreateStorageFail() { }, }, http.StatusBadRequest}, + {"lackStorageName", entity.Storage{ + Type: entity.FakeStorageType, + StorageClassName: namesgenerator.GetRandomName(0), + IP: "256.256.256.256", + PATH: "/myspace", + Fake: &entity.FakeStorage{ + FakeParameter: "Yo", + }, + }, + http.StatusBadRequest}, {"StorageTypeError", entity.Storage{ Name: namesgenerator.GetRandomName(0), StorageClassName: namesgenerator.GetRandomName(1),