From 823deb5091fcda806a7db8df5c1066f2054eaaa9 Mon Sep 17 00:00:00 2001 From: Cassie Liu Date: Tue, 1 Aug 2023 12:10:16 -0400 Subject: [PATCH 1/2] M3-6614 Add Cypress tests for Linode landing page 'Summary View' --- .../smoke-linode-landing-table.spec.ts | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts b/packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts index 3a36e1ddfb8..358bb762853 100644 --- a/packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts +++ b/packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts @@ -350,6 +350,46 @@ describe('linode landing checks', () => { cy.findByText(linode.label).should('be.visible'); }); }); + + it('checks summary view for linode table', () => { + mockGetLinodes(mockLinodes).as('getLinodes'); + cy.visitWithLogin('/linodes'); + cy.wait('@getLinodes'); + + // Check 'Summary View' button works as expected that can be visiable, enabled and clickable + getVisible('[aria-label="Toggle display"]').should('be.enabled').click(); + + mockLinodes.forEach((linode) => { + // Get the upper 3 parent layers to check each table item. + cy.findByText(linode.label) + .should('be.visible') + .parent() + .parent() + .parent() + .within(() => { + cy.findByText('Summary').should('be.visible'); + cy.findByText('IP Addresses').should('be.visible'); + cy.findByText('Access').should('be.visible'); + + cy.findByText('Plan:').should('be.visible'); + cy.findByText('Region:').should('be.visible'); + cy.findByText('Linode ID:').should('be.visible'); + cy.findByText('Created:').should('be.visible'); + }); + }); + + // Toggle the 'List View' button to check the display of table items are back to the original view. + getVisible('[aria-label="Toggle display"]').should('be.enabled').click(); + + cy.findByText('Summary').should('not.exist'); + cy.findByText('IP Addresses').should('not.exist'); + cy.findByText('Access').should('not.exist'); + + cy.findByText('Plan:').should('not.exist'); + cy.findByText('Region:').should('not.exist'); + cy.findByText('Linode ID:').should('not.exist'); + cy.findByText('Created:').should('not.exist'); + }); }); describe('linode landing actions', () => { From 90e59758763640e2697a31cabffba769988db1c4 Mon Sep 17 00:00:00 2001 From: Cassie Liu Date: Fri, 4 Aug 2023 12:17:08 -0400 Subject: [PATCH 2/2] Fixed comments --- .../e2e/core/linodes/smoke-linode-landing-table.spec.ts | 5 +---- .../manager/src/features/Linodes/LinodesLanding/CardView.tsx | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts b/packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts index 358bb762853..3f7600506a5 100644 --- a/packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts +++ b/packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts @@ -360,12 +360,9 @@ describe('linode landing checks', () => { getVisible('[aria-label="Toggle display"]').should('be.enabled').click(); mockLinodes.forEach((linode) => { - // Get the upper 3 parent layers to check each table item. cy.findByText(linode.label) .should('be.visible') - .parent() - .parent() - .parent() + .closest('[data-qa-linode-card]') .within(() => { cy.findByText('Summary').should('be.visible'); cy.findByText('IP Addresses').should('be.visible'); diff --git a/packages/manager/src/features/Linodes/LinodesLanding/CardView.tsx b/packages/manager/src/features/Linodes/LinodesLanding/CardView.tsx index da4be3d1d33..7b29cb00eb0 100644 --- a/packages/manager/src/features/Linodes/LinodesLanding/CardView.tsx +++ b/packages/manager/src/features/Linodes/LinodesLanding/CardView.tsx @@ -68,7 +68,7 @@ const CardView = (props: RenderLinodesProps) => { {data.map((linode, idx: number) => ( - +