Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SerializationPlugin and InitPlugin to replace their respective protocols #4025

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

provinzkraut
Copy link
Member

  • Add SerializationPlugin to replace SerializationPluginProcotol
  • Add InitPlugin to replace InitPluginProtocol

These are the only ones for which the protocols don't have a non-protocol equivalent.

Following the same approach as for other plugins, they inherit their respective protocol for now, to keep type / isinstance checks compatible.

@provinzkraut provinzkraut requested review from a team as code owners February 25, 2025 13:57
@github-actions github-actions bot added area/channels area/docs This PR involves changes to the documentation area/openapi This PR involves changes to the OpenAPI schema area/plugins This PR involves changes to the plugins area/private-api This PR involves changes to the privatized API size: medium type/feat labels Feb 25, 2025
@provinzkraut provinzkraut mentioned this pull request Feb 25, 2025
22 tasks
@provinzkraut
Copy link
Member Author

@cofin Once merged, we can migrate AA to these

@provinzkraut provinzkraut force-pushed the deprecate-plugin-protocols branch from b0b0c50 to 19435e4 Compare February 25, 2025 13:58
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (cd26215) to head (aa7a961).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4025   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         347      347           
  Lines       15803    15811    +8     
  Branches     1747     1747           
=======================================
+ Hits        15543    15551    +8     
  Misses        124      124           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut force-pushed the deprecate-plugin-protocols branch from 19435e4 to 9df7d92 Compare February 25, 2025 14:12
@provinzkraut provinzkraut enabled auto-merge (squash) February 25, 2025 14:19
@provinzkraut provinzkraut force-pushed the deprecate-plugin-protocols branch from 9df7d92 to aa7a961 Compare February 25, 2025 14:19
@provinzkraut provinzkraut merged commit 12d0e8f into main Feb 25, 2025
26 checks passed
@provinzkraut provinzkraut deleted the deprecate-plugin-protocols branch February 25, 2025 14:23
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/channels area/docs This PR involves changes to the documentation area/openapi This PR involves changes to the OpenAPI schema area/plugins This PR involves changes to the plugins area/private-api This PR involves changes to the privatized API pr/internal size: medium type/feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants