Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow non-hashable type args #643

Merged
merged 1 commit into from
Feb 9, 2025
Merged

fix: allow non-hashable type args #643

merged 1 commit into from
Feb 9, 2025

Conversation

adhtruong
Copy link
Collaborator

@adhtruong adhtruong commented Feb 9, 2025 •
edited
Loading

Description

  • Allow non-hashable types by checking
  • Note this would still raise parameter error in some circumstances but does not raise an internal error allowing the user to specify the way to resolve the type

Closes

@adhtruong adhtruong requested a review from guacs as a code owner February 9, 2025 12:02
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/643

@adhtruong adhtruong enabled auto-merge (squash) February 9, 2025 12:05
@adhtruong adhtruong merged commit 64fa119 into main Feb 9, 2025
29 checks passed
@adhtruong adhtruong deleted the fix-nonhashable-type-args branch February 9, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provinzkraut provinzkraut provinzkraut approved these changes

@guacs guacs Awaiting requested review from guacs guacs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: How to handle Callable types
2 participants
@adhtruong @provinzkraut