Adding callbacks for draft creation, update, and destroy #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nine callbacks have been added via ActiveModel::Callbacks: (before | around | after)_draft_creation (before | around | after)_draft_update (before | around | after)_draft_destroy These work very similarly to traditional ActiveRecord callbacks, (e.g. `before_create`), except they are triggered when working with drafts. This commit simply wraps the `draft_creation`, `draft_update`, and `draft_destroy` methods with a `run_callbacks` call. Any callbacks defined on models which have drafts will be run as defined. We only extend models which have drafts, to avoid further cluttering models.
Added 25 specs to test each of the nine draft callbacks. before_draft_creation, around_draft_creation, after_draft_creation before_draft_update, around_draft_update, after_draft_update before_draft_destroy, around_draft_destroy, after_draft_destroy The `Talkative` model contains a few attributes which are modified via these callbacks. The tests check that the attributes are modified correctly, and also check that they're called at the appropriate times.
|
This looks awesome. I'm trying to get all organized-like, so I created a 0.4.0 milestone and placed this in there. I hope to not let issues and pull requests lie around quite as long from this point forth, so this pull request should be included in the gem soon. Thanks! |
|
Sounds good. Let me know if you'd like any changes. |
|
Added docs for these callbacks to complete the circle |
|
I've had to make a couple other changes (unrelated to this PR), and unfortunately I sent this pull request off my master branch. I'm going to close this PR and reopen it off a new branch from my repo so I can make a few other changes (and pull in the upstream). Other than pulling upstream, it won't be any different. |
chrisdpeters
added a commit
that referenced
this pull request
Nov 11, 2015
Resubmitting #14 - Adding callbacks for draft creation, update, and destroy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @chrisdpeters -- I had a few situations where I needed ActiveRecord-style callbacks to run on draft content, e.g.
before_draft_creationrather than ActiveRecord'sbefore_create.This pull request includes support for nine callbacks:
(before | around | after)_draft_creation
(before | around | after)_draft_update
(before | around | after)_draft_destroy
I've included multiple tests for each of these callbacks -- 25 in total.
For the most part, I haven't changed how draftsman works (and the current specs all pass). The
draft_creation,draft_update, anddraft_destroymethods are basically just wrapped by the callbacks. There is one change to model.rb#L225 -- I've moved the 'return' outside of the callbacks to make sure they always have a chance to run (unless there is an exception).Thought you (or others) might find this useful. Let me know if you have questions, or if you'd like me to modify how I'm doing anything.
Thanks!