Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in livekit-api 0.3.4 #363

Open
sdroege opened this issue Jul 8, 2024 · 6 comments
Open

Breaking change in livekit-api 0.3.4 #363

sdroege opened this issue Jul 8, 2024 · 6 comments

Comments

@sdroege
Copy link

sdroege commented Jul 8, 2024

The signal-client feature was removed and replaced by signal-client-tokio, which among other things breaks compilation of the GStreamer livekit plugin.

@sdroege
Copy link
Author

sdroege commented Jul 16, 2024

The GStreamer webrtc plugin is released for now with a < 0.3.4 dependency.

@davidzhao
Copy link
Member

@sdroege sorry about that, we'll submit a PR soon to fix the breakage.

@sdroege
Copy link
Author

sdroege commented Aug 13, 2024

Any updates on this?

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2025
@sdroege
Copy link
Author

sdroege commented Feb 14, 2025

Instead of just closing it by a bot, can some human explain what the plan forward here is?

@davidzhao davidzhao reopened this Feb 17, 2025
@davidzhao
Copy link
Member

this was autoclosed due to inactivity. reopened

@sdroege
Copy link
Author

sdroege commented Feb 18, 2025

Also proto::TrickleRequest got a new final field, which is another breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants