introduce a quic.Config.HandshakeIdleTimeout, remove HandshakeTimeout #2930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1681.
There's a subtle difference between a handshake timeout and the handshake idle timeout: The handshake timeout fires a fixed time after the handshake started, and kills the connection if the handshake hasn't completed by that time.
The handshake idle timeout functions like the normal idle timeout, just with a shorter time for the time before handshake completion.
Ideally, the handshake idle timeout should be shorter than the handshake timeout. We ensure this by setting it to
max(10s, handshake idle timeout)
.This way, we'll be able to give up dialing a peer that's not listening at all earlier. So far, we'd have to wait for the handshake timeout (10s) to finally give up. That's a long time. Now the rule is: If we don't receive any valid QUIC packet for 5 seconds, we give up.