avoid using rand.Source #3046
Merged
avoid using rand.Source #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3046 +/- ##
==========================================
- Coverage 86.20% 86.17% -0.03%
==========================================
Files 131 132 +1
Lines 9356 9352 -4
==========================================
- Hits 8065 8059 -6
- Misses 935 936 +1
- Partials 356 357 +1
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Feb 17, 2021
math/rand.Source uses a lot of memory, as it keeps an array of 607 int64s as internal state.
marten-seemann
force-pushed
the
avoid-rand-source
branch
from
b31cc21 to
03fe636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #3045, which is blocked by CircleCI. @circleci, thanks for slowing down my development workflow!
Fixes #3044.
The alternative would be to use one
rand.Sourcefor all connections, but then we'd have to deal with it not being thread-safe. Reading 4 bytes fromcrypto/randevery 10000 packets shouldn't be too expensive, so we can just use cryptographic random here.