prevent quic-go from building on Go 1.17 #3180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Go 1.17 won't introduce any changes to the structs for which we assert that they're identical between qtls and crypto/tls. That means that in principle, it would be possible to build quic-go using Go 1.17. We should prevent this, as users might expect Go 1.17 crypto/tls to take effect, which they don't as long as we don't create an updated qtls version.
cc @mvdan
The error message will look like this: