Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent quic-go from building on Go 1.17 #3180

Merged
merged 1 commit into from
May 16, 2021
Merged

Conversation

marten-seemann
Copy link
Member

It looks like Go 1.17 won't introduce any changes to the structs for which we assert that they're identical between qtls and crypto/tls. That means that in principle, it would be possible to build quic-go using Go 1.17. We should prevent this, as users might expect Go 1.17 crypto/tls to take effect, which they don't as long as we don't create an updated qtls version.

cc @mvdan

The error message will look like this:

❯ go1.17 test
# github.com/lucas-clemente/quic-go/
internal/qtls/go117.go:3:1: expected 'package', found "quic-go doesn't build on Go 1.17 yet."

@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #3180 (b61e2fa) into master (0bc0e96) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3180   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files         133      133           
  Lines        9819     9819           
=======================================
  Hits         8382     8382           
  Misses       1062     1062           
  Partials      375      375           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc0e96...b61e2fa. Read the comment docs.

Copy link

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a clever way to give a useful compiler error - I'll be copying that :)

@marten-seemann
Copy link
Member Author

That's a clever way to give a useful compiler error

Thanks. Actually, I was hoping that there is an even more direct way to print that error (without the expected 'package', found ...).

@marten-seemann marten-seemann merged commit e08cda5 into master May 16, 2021
@marten-seemann marten-seemann deleted the fail-on-go-1-17 branch May 17, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants