You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The main issue I have with this is that an operation should never be used as a find. That's left to the query objects. I think even though this doesn't perform a DB level upsert, the name still works well since you're either updating a record or inserting a record.
We should look at getting the ON CONFLICT built in to the query builder directly so we can do this in a single query, but I'd like to keep the method name as upsert on this one.
As presented in #789 , the upserts in current avram are more of "find_or_create", instead of utilizing
upsert
from postgres: https://www.postgresql.org/docs/9.5/sql-insert.html (INSERT INTO ... ON CONFLICT UPDATE)This can be confusing to newcomers expecting upsert to be a single UPSERT query.
The text was updated successfully, but these errors were encountered: