-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: revert parsing username via URI due to potential breaking changes (
- Loading branch information
Showing
3 changed files
with
0 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -170,23 +170,6 @@ describe("auth", function () { | |
redis = new Redis({ port: 17379, username, password }); | ||
}); | ||
|
||
it("should handle auth with Redis URL string with username and password (Redis >=6) (redis://foo:[email protected]/) correctly", function (done) { | ||
let username = "user"; | ||
let password = "pass"; | ||
let redis; | ||
new MockServer(17379, function (argv) { | ||
if ( | ||
argv[0] === "auth" && | ||
argv[1] === username && | ||
argv[2] === password | ||
) { | ||
redis.disconnect(); | ||
done(); | ||
} | ||
}); | ||
redis = new Redis(`redis://user:pass@localhost:17379/`); | ||
}); | ||
|
||
it('should not emit "error" when the Redis >=6 server doesn\'t need auth', function (done) { | ||
new MockServer(17379, function (argv) { | ||
if (argv[0] === "auth" && argv[1] === "pass") { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
225ef45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luin Could you elaborate why you reverted this change? I just ran into this issue where trying to init a client by passing a URI containing a username which now doesn't work. Thanks!