Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the Review file is changed, the Commit will not work #25

Closed
EthraZa opened this issue Jan 15, 2016 · 2 comments
Closed

If the Review file is changed, the Commit will not work #25

EthraZa opened this issue Jan 15, 2016 · 2 comments
Milestone

Comments

@EthraZa
Copy link

EthraZa commented Jan 15, 2016

If I ask for Review an action and Commit it without touching the Review file, it will work. But if I change the Review file, like comment out a line so the file does not get deleted or something, it will fail with the followiong error:

Running the contributed command:'extension.ftpsynccommit' failed.
@lukasz-wronski lukasz-wronski added this to the v0.2.x milestone Jan 16, 2016
@lukasz-wronski
Copy link
Owner

It have to be a valid json file. I will add validation and suitable message.

@lukasz-wronski
Copy link
Owner

Added. Will appear on 0.2.9 tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants