Simplify Lang internals #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
force-pushed
the
ap/simplify-nivc-lang
branch
from
0d6636d to
28d13cf
Compare
porcuquine
reviewed
Sep 18, 2023
arthurpaulino
force-pushed
the
ap/simplify-nivc-lang
branch
from
28d13cf to
0667a6b
Compare
porcuquine
approved these changes
Sep 18, 2023
porcuquine
pushed a commit
that referenced
this pull request
Sep 18, 2023
winston-h-zhang
pushed a commit
that referenced
this pull request
Sep 18, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* Implement NIVC Coprocessors. * simplify Lang internals (#678) * sha256 nivc test + fix some arecibo API calls --------- Co-authored-by: porcuquine <[email protected]> Co-authored-by: Arthur Paulino <[email protected]>
winston-h-zhang
pushed a commit
that referenced
this pull request
Sep 19, 2023
winston-h-zhang
pushed a commit
that referenced
this pull request
Sep 20, 2023
winston-h-zhang
pushed a commit
that referenced
this pull request
Sep 26, 2023
winston-h-zhang
pushed a commit
that referenced
this pull request
Sep 29, 2023
winston-h-zhang
pushed a commit
that referenced
this pull request
Sep 29, 2023
winston-h-zhang
pushed a commit
that referenced
this pull request
Sep 29, 2023
simplify Lang internals (#678) uniform `Instance` usage new instance structure, add cli supernova public params finalize instance API add suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove extra fields from
Lang, as anIndexMap, alone, can provide the support we need.This also makes
Langcompletely compatible with #670, which is great.