Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set resolution before obtaining size #425

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

Serafadam
Copy link
Collaborator

Overview

Author: @Serafadam

Issue

Issue link (if present): N/A
Issue description: This is a minor fix to obtain proper width and height for the sensor after setting resolution
Related PRs: N/A

Changes

ROS distro: Humble
List of changes:

  • Move resolution setter above size getters

Testing

Hardware used: OAK-D-PRO
Depthai library version: 2.20.0

Visuals from testing

Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.

@Serafadam Serafadam merged commit e030c4d into humble Oct 6, 2023
@Serafadam Serafadam deleted the resolution_params_fix_humble branch October 6, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant