Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RS Mode & Sync - Humble #578

Merged
merged 25 commits into from
Aug 14, 2024
Merged

RS Mode & Sync - Humble #578

merged 25 commits into from
Aug 14, 2024

Conversation

Serafadam
Copy link
Collaborator

@Serafadam Serafadam commented Aug 13, 2024

Overview

Author: @Serafadam

Issue

Issue link (if present): N/A
Issue description: Adding settings to choose between different ROS interfaces, RS mode publishes topics similar to Realsense cameras. Also, multi topic syncing has been added for image topics.
Related PRs

Changes

ROS distro: Humble
List of changes:

  • Added ImagePublisher class to wrap some redundancy regarding setting up Image publisher, it's a prelude to more common Publisher class which will be added for syncing other topic types.
  • Added Sync node which allows syncing multiple image sources (stereo, rgb, left, right)
  • Updated Node, topic and frame names to also provide RS equivalent
  • Moved RGBD pointcloud and rectify nodes to camera.launch.py for better ease of use
  • Updated raw rclcpp::Node definitions with std::shared_ptrrclcpp::Node
  • Added getLogger() methods for simplification
  • Update deprecated IR interfaces
  • Removed useless utils

Testing

Hardware used: OAK-D-PRO
Depthai library version:2.26.1

Visuals from testing

Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.

@Serafadam Serafadam merged commit 24ce893 into humble Aug 14, 2024
6 checks passed
@Serafadam Serafadam deleted the realsense_compat_mode_humble branch August 14, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant