Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] update installation instructions for macOS (missing dependencies) #162

Closed
ed9w2in6 opened this issue Jun 12, 2023 · 3 comments · Fixed by #222
Closed

[README] update installation instructions for macOS (missing dependencies) #162

ed9w2in6 opened this issue Jun 12, 2023 · 3 comments · Fixed by #222

Comments

@ed9w2in6
Copy link

ed9w2in6 commented Jun 12, 2023

I believe this is an macOS issue only.

In short,

The following dependencies are also needed in addition to the current listed dependencies:

  • libidn2
  • librtmp

On macOS do: brew install libidn2 rtmpdump

Reason:
Both library are both GNU hence some linux distribution may ship with both of them. For instance on my Centos machine your instructions worked, in which macOS does NOT.

@ed9w2in6 ed9w2in6 changed the title [README] missing dependencies for installation instructions [README] update installation instructions for macos (missing dependencies) Jun 12, 2023
@ed9w2in6 ed9w2in6 changed the title [README] update installation instructions for macos (missing dependencies) [README] update installation instructions for macOS (missing dependencies) Jun 12, 2023
@j0sh
Copy link

j0sh commented Jul 6, 2023

Getting the same here on an Intel macOS machine and the 0.5.4 release. In my case, zstd was also missing.

Shouldn't these libraries be statically complied into the build? Librtmp is also unnecessary and should be omitted from the build config.

For anyone else using Nixpkgs on Mac: I got this working under a Nix shell with nix-shell -p libidn2 rtmpdump zstd and adding the library paths (discovered via pkg-config --libs) to a DYLD_FALLBACK_LIBRARY_PATH environment variable to the curl_chrome110 script. Something like this - the exact paths will vary:

DYLD_FALLBACK_LIBRARY_PATH=/nix/store/c4nas454dlkzgam9ihz0sdxqdjyjj3fi-libidn2-2.3.4/lib:/nix/store/shj1rqgqlh47xwg3mh007vbjkdvhnl49-rtmpdump-unstable-2021-02-19/lib:/nix/store/ly3wj661lbrgh5gj07kfx0y8cyqygrl0-zstd-1.5.5/lib "$dir/curl-impersonate-chrome" 

@j0sh
Copy link

j0sh commented Feb 21, 2024

Heads up that this issue still exists for MacOS. For those of you using nix on macos, the nixpkgs workaround mentioned earlier still works.

@lwthiker
Copy link
Owner

lwthiker commented Mar 2, 2024

Thanks, I have taken a look and I see the problem now. The MacOS runner in GitHub comes with librtmp and libidn2 installed, and the curl build system automatically detects that and links them in. I think I'll explicitly disable them so the pre-compiled release binaries do not have them linked in (this is the case in the Linux binaries anyways).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants