-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for User Queue Level Routing #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchoi614
previously approved these changes
Aug 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - added some nit comments and questions
gateway-ha/src/main/java/com/lyft/data/gateway/ha/router/RoutingManager.java
Show resolved
Hide resolved
gateway-ha/src/main/java/com/lyft/data/gateway/ha/router/RoutingManager.java
Show resolved
Hide resolved
gateway-ha/src/main/java/com/lyft/data/gateway/ha/router/PrestoQueueLengthRoutingTable.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/com/lyft/data/gateway/ha/router/TestPrestoQueueLengthRoutingTable.java
Show resolved
Hide resolved
gateway-ha/src/test/java/com/lyft/data/gateway/ha/router/TestPrestoQueueLengthRoutingTable.java
Show resolved
Hide resolved
gateway-ha/src/main/java/com/lyft/data/gateway/ha/clustermonitor/ActiveClusterMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/com/lyft/data/gateway/ha/clustermonitor/ActiveClusterMonitor.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/com/lyft/data/gateway/ha/clustermonitor/ActiveClusterMonitor.java
Show resolved
Hide resolved
charlessong-lyft
previously approved these changes
Aug 23, 2022
707763b
to
9e33f46
Compare
charlessong-lyft
approved these changes
Aug 29, 2022
charlessong-lyft
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Routing to cluster with the least queue for the User, fallback to existing Cluster Queue based Routing approach if user level queue size are equal/no-queue.
Makes use of "ui/api/query?state=QUEUED" on the coordinator to fetch the current queued queries on the cluster.
This is internal change to the routing manager but given this is a sizable change, I plan to bump up the version to
1.9.0
with this release