Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crawl): callback to run when link is found #13

Merged
merged 2 commits into from
Feb 11, 2022
Merged

feat(crawl): callback to run when link is found #13

merged 2 commits into from
Feb 11, 2022

Conversation

j-mendez
Copy link
Member

  1. add ability to do something on individual link find

Screen Shot 2022-02-10 at 8 53 03 PM

@j-mendez j-mendez mentioned this pull request Feb 11, 2022
Closed
@madeindjs
Copy link
Contributor

Thanks for your contricontribution ❤️ LGTM but can you add a test that callback is called ?

@j-mendez
Copy link
Member Author

Thanks for your contricontribution ❤️ LGTM but can you add a test that callback is called ?

Your welcome! Yes I will get to this by the EOD. 🙌

@j-mendez
Copy link
Member Author

@madeindjs added a quick test, should be good to go =)

@madeindjs madeindjs merged commit d5be1dc into spider-rs:master Feb 11, 2022
@madeindjs
Copy link
Contributor

Thank for your contribution ❤️

@madeindjs
Copy link
Contributor

published on v1.3.0

@j-mendez j-mendez deleted the patch-1 branch February 11, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madeindjs madeindjs madeindjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mendez @madeindjs