Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hinting #148

Open
staticdev opened this issue Dec 28, 2021 · 6 comments
Open

Add type hinting #148

staticdev opened this issue Dec 28, 2021 · 6 comments
Labels
testing Testing

Comments

@staticdev
Copy link
Collaborator

staticdev commented Dec 28, 2021

  • Add static type checks
  • Add dynamic type checks
@staticdev staticdev added the testing Testing label Dec 28, 2021
@jayrod
Copy link

jayrod commented Feb 21, 2022

Love using the library, works awesome. Question though. Would it be possible to generate an array of questions given a dataclass as input? Or is that way out of scope for this library?

@Lonerider2010
Copy link

As mypy states: Skipping analyzing "inquirer": found module but no type hints or library stubs.
So please tell me what is the status of this issue?

@staticdev
Copy link
Collaborator Author

@Lonerider2010 0% done unfortunatelly. You have options:

  1. Add to mypy ignore (as I used to do)
  2. Use a similar typed library (such as prompt-toolkit)
  3. Contribute with a PR and I will be glad to review it

@magmax
Copy link
Owner

magmax commented Jun 23, 2022 via email

@Lonerider2010
Copy link

@magmax Thanks for your reply. According to mutable types: What about Union? Or if nothing else helps, there is still the type hint Any...
So my conclusion is: Adding type hinting to Inquirer would help a lot, definitely not only to me.

@Lonerider2010
Copy link

BTW. the answer to @jayrod's question is of great interest for me, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing
Projects
None yet
Development

No branches or pull requests

4 participants