feat(client): implement ClientOperationCfg to control any client oper… #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
reviewed
Feb 4, 2025
| @@ -22,7 +22,6 @@ color-eyre = "0.6.3" | |||
| crdts = { version = "7.3", default-features = false, features = ["merkle"] } | |||
| custom_debug = "~0.6.1" | |||
| dirs-next = "~2.0.0" | |||
| exponential-backoff = "2.0.0" | |||
There was a problem hiding this comment.
Very good that we removed that from the protocol layer!
grumbach
reviewed
Feb 4, 2025
autonomi/src/client/config.rs
Outdated
Comment on lines
53
to
118
| pub struct ChunkOperationConfig { | ||
| /// The retry strategy to use if we fail to store a chunk. Every write will also verify that the chunk | ||
| /// is stored on the network by fetching it back. | ||
| /// | ||
| /// Use the `verification_quorum` and `verification_retry_strategy` to configure the verification operation. | ||
| pub(crate) write_retry_strategy: RetryStrategy, | ||
| /// The number of chunks to wait for before considering the read after write operation successful. | ||
| pub(crate) verification_quorum: ResponseQuorum, | ||
| /// The retry strategy to use if the read after write operation fails. | ||
| pub(crate) verification_retry_strategy: RetryStrategy, | ||
| /// The number of chunks to wait for before considering the read operation successful. | ||
| pub(crate) read_quorum: ResponseQuorum, | ||
| /// The retry strategy to use if the read operation fails. | ||
| pub(crate) read_retry_strategy: RetryStrategy, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct GraphOperationConfig { | ||
| /// The retry strategy to use if we fail to store a graph entry. Every write will also verify that the entry | ||
| /// is stored on the network by fetching it back. | ||
| /// | ||
| /// Use the `verification_quorum` and `verification_retry_strategy` to configure the verification operation. | ||
| pub(crate) write_retry_strategy: RetryStrategy, | ||
| /// The number of entries to wait for before considering the read after write operation successful. | ||
| pub(crate) verification_quorum: ResponseQuorum, | ||
| /// The retry strategy to use if the read after write operation fails. | ||
| pub(crate) verification_retry_strategy: RetryStrategy, | ||
| /// The number of entries to wait for before considering the read operation successful. | ||
| pub(crate) read_quorum: ResponseQuorum, | ||
| /// The retry strategy to use if the read operation fails. | ||
| pub(crate) read_retry_strategy: RetryStrategy, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct PointerOperationConfig { | ||
| /// The retry strategy to use if we fail to store a pointer. Every write will also verify that the pointer | ||
| /// is stored on the network by fetching it back. | ||
| /// | ||
| /// Use the `verification_quorum` and `verification_retry_strategy` to configure the verification operation. | ||
| pub(crate) write_retry_strategy: RetryStrategy, | ||
| /// The number of pointers to wait for before considering the read after write operation successful. | ||
| pub(crate) verification_quorum: ResponseQuorum, | ||
| /// The retry strategy to use if the read after write operation fails. | ||
| pub(crate) verification_retry_strategy: RetryStrategy, | ||
| /// The number of pointers to wait for before considering the read operation successful. | ||
| pub(crate) read_quorum: ResponseQuorum, | ||
| /// The retry strategy to use if the read operation fails. | ||
| pub(crate) read_retry_strategy: RetryStrategy, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct ScratchpadOperationConfig { | ||
| /// The retry strategy to use if we fail to store a scratchpad. Every write will also verify that the scratchpad | ||
| /// is stored on the network by fetching it back. | ||
| /// | ||
| /// Use the `verification_quorum` and `verification_retry_strategy` to configure the verification operation. | ||
| pub(crate) write_retry_strategy: RetryStrategy, | ||
| /// The number of scratchpads to wait for before considering the read after write operation successful. | ||
| pub(crate) verification_quorum: ResponseQuorum, | ||
| /// The retry strategy to use if the read after write operation fails. | ||
| pub(crate) verification_retry_strategy: RetryStrategy, | ||
| /// The number of scratchpads to wait for before considering the read operation successful. | ||
| pub(crate) read_quorum: ResponseQuorum, | ||
| /// The retry strategy to use if the read operation fails. | ||
| pub(crate) read_retry_strategy: RetryStrategy, | ||
| } |
There was a problem hiding this comment.
Those are exactly the same please make this one type. If in the future we need to make them different, we will. But for now, please let's keep this simple.
There was a problem hiding this comment.
Updated. But this would mean that we lose the ability to set the cfgs in one place. We reuse the configs at some places and those might be prone to errors.
There was a problem hiding this comment.
Ok will address that in a follow up then
grumbach
reviewed
Feb 4, 2025
Comment on lines
-259
to
+243
| evm_network: config.evm_network, | ||
| evm_network: Arc::new(config.evm_network), | ||
| operation_config: Arc::new(config.operation_config), |
There was a problem hiding this comment.
Every component Network is arc'ed to be freely clonable without incurring much cost, so I assume we'd want to do the same for Clients.
grumbach
reviewed
Feb 4, 2025
autonomi/src/lib.rs
Outdated
Comment on lines
91
to
97
| // Client Configs | ||
| config::ChunkOperationConfig, | ||
| config::ClientConfig, | ||
| config::ClientOperationConfig, | ||
| config::GraphOperationConfig, | ||
| config::PointerOperationConfig, | ||
| config::ScratchpadOperationConfig, |
There was a problem hiding this comment.
Making this one type will make the exposed types much simpler, 6 exposed public structs related to config is huge
grumbach
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Thanks for making this PR @RolandSherwin! Apart form the config types duplication LGTM!
RolandSherwin
force-pushed
the
uploader_metrics_1_config
branch
from
88d5572 to
37bfc3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.