Add a custom error message for a missing alias after 'aggregate:' #2144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
I added a helpful error message: "'aggregate:' entries must include a name (ex:
some_name is count()
)"Add an error message rewriter for the case:
Was:
Now:
I also wanted to make sure we could support the aggregate error even when it is nested inside of a view. To do so, we couldn't rely on the same logic because the parser fails to parse the entire
view:
clause. Instead, I added a new error rewriter optionlookbackFromOffendingSymbol
that lets us do relative sequence comparisons from the token associated with the error, rather than the token associated with the parser's current position. The Malloy grammar has a lot of ambiguity that is resolved by lookahead logic in the ATN and so we cannot rely on thecurrentToken
to be up-to-date when an error is hit.Was:
Now: