Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Test with Xcode 10/iOS 12 betas on CircleCI #12756

Closed
friedbunny opened this issue Aug 28, 2018 · 5 comments
Closed

Test with Xcode 10/iOS 12 betas on CircleCI #12756

friedbunny opened this issue Aug 28, 2018 · 5 comments
Assignees
Labels
build iOS Mapbox Maps SDK for iOS

Comments

@friedbunny
Copy link
Contributor

friedbunny commented Aug 28, 2018

CircleCI has added an Xcode 10 (beta 5 😞) container and the release date for Xcode 10/iOS 12 is approaching (likely mid-September), so it’s about time we formally added a temporary job that exercises the new bits.

/cc @mapbox/maps-ios

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS build labels Aug 28, 2018
@friedbunny friedbunny self-assigned this Sep 5, 2018
@friedbunny
Copy link
Contributor Author

friedbunny commented Sep 5, 2018

I’ve been working on this and it seems like any test with a timeout can and will fail under Xcode 10 on CircleCI. Local tests are solid, but I’m seeing a variety of "Asynchronous wait failed: Exceeded timeout of x seconds” on CircleCI in:

  • MGLMapViewLayoutTests.testOrnamentPlacement
  • MGLOfflineStorageTests.testAddPackForBounds
  • MGLStyleTests.testLayersOrder
  • Others...

@julianrex
Copy link
Contributor

@friedbunny wondering if we need to add explicit dependencies, similar to mapbox/ios-sdk-examples#221 (comment).

@friedbunny
Copy link
Contributor Author

CircleCI has updated to Xcode 10 GM.

@friedbunny
Copy link
Contributor Author

friedbunny commented Sep 18, 2018

After bumping timeouts, most tests pass and don’t approach the new timeout limit (though some do, occasionally). Performance seems wildly variable with Xcode 10 tests on CI so far.

I’m also seeing PENDING tests fail, which doesn’t seem correct:

MBCameraTransitionTests
    ✗ testContinuallyResettingNorthInIsChangingPENDING, Asynchronous wait failed: Exceeded timeout of 1 seconds, with unfulfilled expectations: "Map view should finish loading style.".
    '-[MBCameraTransitionTests testContinuallyResettingNorthInIsChangingPENDING]' is a pending test - skipping
    '-[MBCameraTransitionTests testContinuallySettingCoordinateInIsChangingPENDING]' is a pending test - skipping
    ⧖ testContinuallySettingCoordinateInIsChanging [PENDING]

@friedbunny
Copy link
Contributor Author

Finally a green run.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

2 participants