Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Clockwise map rotation gesture is broken after core camera refactor #14073

Closed
friedbunny opened this issue Mar 9, 2019 · 1 comment · Fixed by #14082
Closed

Clockwise map rotation gesture is broken after core camera refactor #14073

friedbunny opened this issue Mar 9, 2019 · 1 comment · Fixed by #14082
Assignees
Labels
bug Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS release blocker Blocks the next final release

Comments

@friedbunny
Copy link
Contributor

Steps to reproduce

  1. Pinch-rotate a map clockwise.

Expected behavior

Map rotates and stays rotated (if the zoom level is sufficient to allow rotation).

Actual behavior

Map rotates for the duration of the gesture, but erroneously snaps back to 0° when the gesture is released.

Configuration

Mapbox SDK versions: ios-v4.10.0-alpha.1

This bisects to 73ac3c7 (#14017) by @brunoabinader and, so far, only exists in the ios-v4.10.0-alpha.1 release. Have not confirmed if this affects other platforms.

/cc @julianrex @tobrun

@friedbunny friedbunny added bug iOS Mapbox Maps SDK for iOS Core The cross-platform C++ core, aka mbgl labels Mar 9, 2019
@friedbunny friedbunny added this to the release-l milestone Mar 9, 2019
@friedbunny friedbunny self-assigned this Mar 9, 2019
@friedbunny friedbunny added the macOS Mapbox Maps SDK for macOS label Mar 9, 2019
@friedbunny
Copy link
Contributor Author

This manifests slightly differently on macOS:

ezgif com-optimize

Rotation works as expected, but the compass doesn’t update until you pass a certain threshold.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS release blocker Blocks the next final release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants