Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add Non English Language Example To Test App #5493

Closed
bleege opened this issue Jun 27, 2016 · 7 comments
Closed

Add Non English Language Example To Test App #5493

bleege opened this issue Jun 27, 2016 · 7 comments
Labels
Android Mapbox Maps SDK for Android

Comments

@bleege
Copy link
Contributor

bleege commented Jun 27, 2016

The world is a big place with many different languages spoken. We should better highlight (and have an automated test) that the Mapbox Android SDK supports different languages both at the Core GL and with the View based levels. While RTL support hasn't landed (yet) #5072 we can certainly show an example that uses a language like French, Spanish, or German to illustrate how this would work.

As we discussed internally this morning, this would also be a great example to port to the Mapbox Android Demo app.

/cc @zugaldia @cammace

@bleege bleege added the Android Mapbox Maps SDK for Android label Jun 27, 2016
@1ec5
Copy link
Contributor

1ec5 commented Jun 27, 2016

Would this use the same approach as this GL JS example (which requires #837), or would it use a separate Mapbox Studio style for now?

@tmpsantos
Copy link
Contributor

✋ volunteer for portuguese translation, just ping me.

@1ec5
Copy link
Contributor

1ec5 commented Jul 13, 2016

I think this ticket is about map localization. Mapbox Streets source unfortunately doesn't include Portuguese names outside of Portuguese-speaking areas.

@tmpsantos
Copy link
Contributor

@1ec5 oh, I took it as for translating the app itself. My bad.

@cammace
Copy link
Contributor

cammace commented Aug 3, 2016

This is an example that is better suited for the Android demo app. Here's the example I've built:
ezgif com-video-to-gif

Note that the tiles aren't refreshing currently like they should be, ticketed here. Closing issue.

@cammace cammace closed this as completed Aug 3, 2016
@bleege
Copy link
Contributor Author

bleege commented Aug 9, 2016

the Mapbox Android SDK supports different languages both at the Core GL and with the View based levels.

I'm re-opening this as it's still missing the View based level examples (thinking InfoWindows). It's also something that we can add unit tests to be more complete and help minimize regressions.

@bleege bleege reopened this Aug 9, 2016
@cammace
Copy link
Contributor

cammace commented Sep 21, 2016

Different languages at the view based levels are controlled by Android, not Mapbox therefore adding more to the example would only complicate things instead of keeping it simple. The example found in the demo app is adequate enough for testing and demoing that we support this.

@cammace cammace closed this as completed Sep 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

4 participants