Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Code-generate runtime styling portion of umbrella header #5955

Closed
1ec5 opened this issue Aug 11, 2016 · 3 comments
Closed

Code-generate runtime styling portion of umbrella header #5955

1ec5 opened this issue Aug 11, 2016 · 3 comments
Labels
archived Archived because of inactivity build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 11, 2016

Per #5727 (comment), it’s a bit of a chore to keep the umbrella header up-to-date. We should break out the runtime styling imports into a separate, code-generated header and include that header. MapKit’s umbrella header is modularized like this too. We’ll need to make sure jazzy can follow the imports and all the supported build configurations continue to work all the way through to App Store validation.

/cc @frederoni @friedbunny

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS build refactor macOS Mapbox Maps SDK for macOS labels Aug 11, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 11, 2016
@boundsj boundsj modified the milestones: ios-3.4.1, ios-v3.4.0 Oct 30, 2016
@1ec5 1ec5 modified the milestones: ios-future, ios-v3.4.1 Jan 24, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 24, 2017

Not critical. Moving off the v3.4.1 milestone.

@1ec5
Copy link
Contributor Author

1ec5 commented Apr 11, 2017

We can also have the runtime styling generating code add any new runtime styling files to the Xcode project using the xcode npm package. That’ll take care of most of the manual steps to adding a new layer or source type. On the other hand, that doesn’t happen very frequently.

/cc @kkaefer

@stale stale bot added the archived Archived because of inactivity label Nov 10, 2018
@stale
Copy link

stale bot commented Nov 27, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor
Projects
None yet
Development

No branches or pull requests

2 participants