Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

NSValue (MGLStyleEnumAttributeAdditions) declares unprefixed properties #7168

Closed
1ec5 opened this issue Nov 23, 2016 · 1 comment
Closed

NSValue (MGLStyleEnumAttributeAdditions) declares unprefixed properties #7168

1ec5 opened this issue Nov 23, 2016 · 1 comment
Assignees
@boundsj
Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 23, 2016

#7061 added category properties on NSValue with names like lineCap. When categorizing a class we don’t declare, we need to use a class prefix to avoid conflicts. lineCap should be renamed to MGLLineCapValue for consistency with existing category properties on NSValue like MGLCoordinateValue and MKCoordinateValue.

/cc @boundsj
@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels Nov 23, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Nov 23, 2016
@boundsj boundsj self-assigned this Nov 23, 2016
@boundsj boundsj mentioned this issue Nov 23, 2016
Merged
@boundsj
Copy link
Contributor

boundsj commented Nov 23, 2016

Fixed in #7171

@boundsj boundsj closed this as completed Nov 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@boundsj boundsj

Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Milestone
ios-v3.4.0
Development

No branches or pull requests
2 participants
@boundsj @1ec5