Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Tap gesture recognizer should fail unless annotation is nearby #7194

Closed
1ec5 opened this issue Nov 26, 2016 · 3 comments
Closed

Tap gesture recognizer should fail unless annotation is nearby #7194

1ec5 opened this issue Nov 26, 2016 · 3 comments
Labels
annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 26, 2016

MGLMapView’s built-in UITapGestureRecognizer should set its state to UIGestureRecognizerStateFailed as soon as it discovers that no annotations are nearby. Combined with #2278, the developer would be able to install their own “fallback” tap gesture recognizer that handles taps when the built-in gesture recognizer, meant for annotation selection, has nothing to select.

/cc @danpat @incanus

@1ec5 1ec5 added annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Nov 26, 2016
@1ec5 1ec5 added this to the ios-future milestone Nov 26, 2016
@danpat
Copy link

danpat commented Nov 26, 2016

I hit this. I have annotations on the map, but I would also like to allow the user to tap elsewhere on the map and perform a feature lookup using visibleFeaturesAtPoint:.

@1ec5 1ec5 modified the milestones: ios-3.4.1, ios-future Nov 28, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 28, 2016

Note that the recognizer should not fail if an annotation is already selected and tapping closes the annotation’s callout view.

@1ec5
Copy link
Contributor Author

1ec5 commented Dec 1, 2016

Fixed in #7246.

@1ec5 1ec5 closed this as completed Dec 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

2 participants