Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

RuntimeStyle template files do not conform to checkstyle #7659

Closed
tobrun opened this issue Jan 10, 2017 · 1 comment
Closed

RuntimeStyle template files do not conform to checkstyle #7659

tobrun opened this issue Jan 10, 2017 · 1 comment
Labels
Android Mapbox Maps SDK for Android good first issue Good for newcomers
Milestone
android-v5.0.0

Comments

@tobrun
Copy link
Member

tobrun commented Jan 10, 2017

When updating classes from our Runtime style implementation in #7658 in the related ejs template files, I noticed that our CI job is failing on checkstyle because the ejs template files weren't updated as part of #7442.

cc @cammace
@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jan 10, 2017
@tobrun tobrun added this to the android-v5.0.0 milestone Jan 10, 2017
@tobrun tobrun added the good first issue Good for newcomers label Jan 10, 2017
@tobrun tobrun mentioned this issue Jan 10, 2017
Merged
@Guardiola31337 Guardiola31337 mentioned this issue Feb 22, 2017
Closed
@tobrun
Copy link
Member Author

tobrun commented Feb 22, 2017

This was resolved when DDS landed, thank you @ivovandongen for picking this up. Closing

@tobrun tobrun closed this as completed Feb 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android good first issue Good for newcomers
Projects
None yet
Milestone
android-v5.0.0
Development

No branches or pull requests
1 participant
@tobrun