Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Android: Remove SQLite library #8048

Closed
kkaefer opened this issue Feb 14, 2017 · 3 comments
Closed

Android: Remove SQLite library #8048

kkaefer opened this issue Feb 14, 2017 · 3 comments
Labels
Android Mapbox Maps SDK for Android

Comments

@kkaefer
Copy link
Member

kkaefer commented Feb 14, 2017

In #2856, we removed cURL in favor of native Android APIs. However, we're still using a compiled version of SQLite, since the SQLite library that ships with Android is inaccessible and only exposed in Java.

There are two ways to accomplish this:

  • Implement the low-level API (sqlite3.hpp with a backend that uses Ithe Java API calls
  • Implement the OfflineDatabase object in Java

#2356

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Feb 14, 2017
@kkaefer
Copy link
Member Author

kkaefer commented Feb 14, 2017

I got started on implementing the low-level API, but the Java bindings are a little overengineered and it doesn't seem to be possible to replicate the interface we're using in sqlite3.hpp with the Java bindings without massive changes. That leaves implementing OfflineDatabase as the only alternative. I'm not feeling super good about adding a second implementation that needs to maintain parity. Thoughts @jfirebaugh?

@kkaefer
Copy link
Member Author

kkaefer commented Feb 14, 2017

For reference, progress stored in https://github.com/mapbox/mapbox-gl-native/tree/8048-android-sqlite, but I don't think it's viable as per the comment above.

@jfirebaugh
Copy link
Contributor

If using Java bindings for SQLite isn't viable, then I recommend we simply stick with the current implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

3 participants