Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Revisit log level for HTTP permanent errors #9638

Closed
danswick opened this issue Jul 28, 2017 · 4 comments
Closed

Revisit log level for HTTP permanent errors #9638

danswick opened this issue Jul 28, 2017 · 4 comments
Labels
Android Mapbox Maps SDK for Android

Comments

@danswick
Copy link
Contributor

The Mapbox Android SDK currently includes verbose logs for all canceled HTTP requests. While this makes sense for unknown errors, it can cause an unexpectedly large amount of logging for apps that are designed to work in a mostly offline environment and should be revisited to determine if the amount of logs should be reduced.

cc @zugaldia

@danswick danswick added the Android Mapbox Maps SDK for Android label Jul 28, 2017
@tobrun
Copy link
Member

tobrun commented Jul 28, 2017

I'm proposing to add a debug flag indicating we want to see all the logs vs errors only.

@tobrun tobrun added this to the android-v5.2.0 milestone Jul 28, 2017
@tobrun
Copy link
Member

tobrun commented Jul 28, 2017

Alternatively we could also allow setting a log level so only logs of that level and higher are printed.

@zugaldia
Copy link
Member

I'm proposing to add a debug flag indicating we want to see all the logs vs errors only.

I like the idea. In order to expedite a quick change though that could make it to the next patch released, how about we ticket that separately?

Alternatively we could also allow setting a log level so only logs of that level and higher are printed.

Considering we're using Timber under the hood, isn't this already available to developers by changing the default DebugTree to a custom less verbose one?

@Guardiola31337
Copy link
Contributor

I like the idea. In order to expedite a quick change though that could make it to the next patch released, how about we ticket that separately?

Ticket 👉 #9681

Considering we're using Timber under the hood, isn't this already available to developers by changing the default DebugTree to a custom less verbose one?

Yeah, we could do that extending Timber.Tree 👀 https://github.com/JakeWharton/timber/blob/master/timber-sample/src/main/java/com/example/timber/ExampleApp.java

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

4 participants