Unset Default temperature unit

[ThePreviousOne]

[ildar]

You seem to have temperature in Kelvin. Is that what you intended?

[ThePreviousOne]

No, actually it was unset....? Just checked. 297 K is cold isn't it?
BTW I'm on v1.4

[ildar]

No, it's 24 of Celsius

[ThePreviousOne]

ya setting the value fixed it

[ThePreviousOne]

Unrelated did you just know that conversion or was some calculator involved ... I'm impressed

[ildar]

That's in school program of physics 😉

[robinpaulson]

Appears resolved, closing

[robinpaulson]

As @brarcher points out, this is not actually resolved.

Suggestions what to do?

[DerVerruckteFuchs]

I'm getting a similar issue with the default temperature being measured in Kelvin, but I'm getting "F" for my unit. Normally Fahrenheit is "°F". Is the unit being set based on locale or location? The alpha/char portion of the unit seems to be set to a decent default, save for the missing "°". It seems that whatever detection is being used to determine a default unit is not quite complete. Assuming that's intended behavior.

[DerVerruckteFuchs]

Alright, so I cleared my app cache/config for Forcastie, force stopped it, and switched my system language to "English (United Kingdom)" from "English (United States)". Upon restarting the app I got my default location as "London, GB" with "C" as my units. Temperature is still in Kelvin. It seems part of the defaults are locale/system language based.

[robinpaulson]

@DerVerruckteFuchs I'm not sure how units are selected, I assumed it was by the user, ignoring locale

[robinpaulson]

This code:
https://github.com/martykan/forecastie/blob/master/app/src/main/java/cz/martykan/forecastie/utils/UnitConvertor.java

show no indication that temperature units are selected by locale.

[robinpaulson]

martykan made some changes yesterday, they may have fixed the problem.
6870c15

If it builds OK, I may move v1.5 forward by 3 weeks, or more likely do a maintenance fix of v1.4.2

[robinpaulson]

Closing, this will appear in v1.5 in a few days