Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitConvertor.java - move string values to strings.xml #337

Closed
igor-cali opened this issue Mar 22, 2019 · 6 comments
Closed

UnitConvertor.java - move string values to strings.xml #337

igor-cali opened this issue Mar 22, 2019 · 6 comments
Labels
bug translation

Comments

@igor-cali
Copy link
Contributor

The functions convertUvIndexToRiskLevel and getBeaufortName return hard-coded strings, which result in untranslated text in the final app.

They should be moved to the resource strings, so they can be translated.
@robinpaulson
Copy link
Contributor

Yep, I agree.

@robinpaulson
Copy link
Contributor

I'll have a go at this, it shouldn't be too difficult.

@robinpaulson robinpaulson pinned this issue Mar 23, 2019
@robinpaulson robinpaulson unpinned this issue Mar 23, 2019
@Linkid
Copy link
Contributor

Linkid commented Aug 10, 2019

Hi. Are you still on it ?

@robinpaulson
Copy link
Contributor

I've been slack is the answer, I may have over-committed myself. If you'd like to try, go for it.

@FridoDeluxe
Copy link
Contributor

#360

@robinpaulson
Copy link
Contributor

Thanks @FridoDeluxe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FridoDeluxe @robinpaulson @Linkid @igor-cali