Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icons for light rain and for app #352

Closed
htopkill opened this issue May 27, 2019 · 7 comments
Closed

Change icons for light rain and for app #352

htopkill opened this issue May 27, 2019 · 7 comments

Comments

@htopkill
Copy link

[enhancement]

  • The picture used for 'light rain' should be different from moderate/heavy rain.
  • The app icon could be better (it's ugly. your app deserves a better icon :-) )
    thank you
@robinpaulson
Copy link
Contributor

  1. yes, i agree. i believe the icons are from an existing font set; adding to it it not trivial. neither is it a gigantic task though.
  2. , sure. it's simple, low priority i guess.

if you want to fix either, go for it.

@robinpaulson robinpaulson changed the title [enhancement] change pictures for light rain Change icons for light rain and for app May 27, 2019
@robinpaulson
Copy link
Contributor

The source of the icons is here:
https://erikflowers.github.io/weather-icons/

@robinpaulson
Copy link
Contributor

If you want to suggest a particular weather condition should use a different icon to what it currently does, go for it. Or make a pull request if you're confident with coding.

@FridoDeluxe
Copy link
Contributor

Concerning the first enhancement suggestion with more suitable weather icons:
On https://erikflowers.github.io/weather-icons/api-list.html is even a list which icon belongs to which weather condition code from OWM. Implementing this list should not be that hard, I could try do do that. Or does anybody wants to stay with as few icons as possible for simplicity?

@FridoDeluxe
Copy link
Contributor

I did prepare pull request #359 to provide a suitable icon for every weather condition code from OWM. There is a fallback icon for every main weather condition in case I missed a condition code or there are undocumented ones. The string value names of the icons are now named like the classes from http://weathericons.io/.

@robinpaulson
Copy link
Contributor

We'll see how it goes and close if the next release works OK. I'll put it out later today

@robinpaulson
Copy link
Contributor

Looking good @FridoDeluxe , thanks for the great work. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants