Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make convert() handle unknown characters. mathjax/MathJax#2309 #432

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Make convert() handle unknown characters. mathjax/MathJax#2309 #432

merged 1 commit into from
Jan 30, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jan 26, 2020 •
edited
Loading

This PR makes sure that the MathItem created in the convert() command has a location in the document (by setting it to the document's body element) so that if unknown characters need to be measured, that doesn't lead to an error (see the original issue linked below).

Resolved issue mathjax/MathJax#2309

@dpvc dpvc changed the title Make convert() handle unknown characters. #2309 Make convert() handle unknown characters. mathjax/MathJax#2309 Jan 26, 2020
zorkow
zorkow approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit ead6dc8 into develop Jan 30, 2020
@dpvc dpvc deleted the issue2309 branch January 30, 2020 18:04
@dpvc dpvc added this to the 3.0.1 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @zorkow