Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move output/common/CssStyles.ts to util/StyleList.ts #493

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented May 13, 2020

This moves the CssStyles.ts file to the util and renames it StyleList.ts (to distinguish it from the Styles.ts file already in that directory, and because StyleList is the most common import from this file).

It also creates a compatibility CssStyles.ts file that simply exports the contexts of StyleList.ts so that in case anyone is using this file in their own code, their code won't break and they can have a chance to rename the files before the next version (where the compatibility file should be removed).

@dpvc dpvc added this to the v3.1.0 milestone May 13, 2020
@dpvc dpvc requested a review from zorkow May 13, 2020 14:32
Base automatically changed from pretty-components to pretty-code May 26, 2020 16:56
@dpvc dpvc changed the base branch from pretty-code to develop May 26, 2020 17:34
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 7040164 into develop Jun 15, 2020
@dpvc dpvc deleted the stylelist branch June 15, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants