Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remap stretchy characters (mathjax/MathJax#2497) #538

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Aug 14, 2020

The PR fixes a problem where a stretchy delimiter that turns out to be rendered as a single character might be remapped to another character inadvertently. Stretchy characters should not be remapped, which is handled here by moving the test for the stretchy character to outside the remapping.

Resolves the second part of mathjax/MathJax#2497.

@dpvc dpvc requested a review from zorkow August 14, 2020 17:01
@dpvc dpvc added this to the v3.1.0 milestone Aug 14, 2020
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
But it feels like the first two lines in each else should go into a util method of their own.

@dpvc
Copy link
Member Author

dpvc commented Aug 17, 2020

Good call. I've added the service routine.

@dpvc dpvc merged commit d3b2389 into develop Aug 17, 2020
@dpvc dpvc deleted the issue2497-b branch August 17, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants