Handle AsciiMath configuration properly, in particular, displaystyle. (mathjax/MathJax#2520) #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with AsciiMath:
The AsciiMath component configuration was not properly handled (it was being processed too late, after AsciiMath had already been configured, and the AsciiMath parameters were being flagged as having no default value (they are only defined in the legacy code, not the new Typescript code).
The conversion from the legacy internal format was not properly handling boolean values, which caused the
displaystyleconfiguration option to be always treated as false.Resolves issue mathjax/MathJax#2520.