Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing support for \ref and \eqref in textmacros. (mathjax/MathJax#2528) #551

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Sep 8, 2020

This PR adds missing support for \ref and \eqref in the textmacros extension. The macros were mapped, but the method for them was missing, and the TextParser needed to use the tags object from the original TexParser in order to be able access the correct tagging data.

Resolves issue mathjax/MathJax#2528.

@dpvc dpvc requested a review from zorkow September 8, 2020 13:58
@dpvc dpvc added this to the 3.1.1 milestone Sep 8, 2020
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 3c1c633 into develop Sep 12, 2020
@dpvc dpvc deleted the issue2528 branch September 12, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants